speed up is_compatible; makes event_source factory faster #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #927 +/- ##
=========================================
- Coverage 78.11% 77.82% -0.3%
=========================================
Files 185 185
Lines 10557 10573 +16
=========================================
- Hits 8247 8228 -19
- Misses 2310 2345 +35
Continue to review full report at Codecov.
|
|
FYI coverage went down, since I added untested code. |
kosack
approved these changes
Jan 23, 2019
|
@watsonjj could your approve again quickly? Another commit removed your previous review .... I'm sorry. |
watsonjj
approved these changes
Jan 23, 2019
watsonjj
added a commit
to watsonjj/ctapipe
that referenced
this pull request
Jan 23, 2019
* master: Major coordinate refactoring, fixes cta-observatory#899, cta-observatory#900, cta-observatory#505, cta-observatory#416 (cta-observatory#896) speed up is_compatible; makes event_source factory faster (cta-observatory#927) Prefix containers (cta-observatory#833) remove optional deps in order to fix tests (cta-observatory#925) Charge Resolution Update (cta-observatory#827) Remove serializer, fixes cta-observatory#887 (cta-observatory#913) deleted summary.html - accidentally committed file (cta-observatory#919) # Conflicts: # ctapipe/tools/extract_charge_resolution.py # examples/simple_event_writer.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a commit from #916 where @watsonjj said, this is useful and should be in the master anyway.